RFR: 8257831: Suspend with handshakes [v2]

[Robbin Ehn]

On Tue, 30 Mar 2021 13:28:14 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/handshake.cpp line 715:
> 
>> 713: bool HandshakeState::resume() {
>> 714:   // Can't be suspended if there is no suspend request.
>> 715:   if (!is_suspend_requested()) {
> 
> Shouldn't `is_suspend_requested()` be replaced with `is_suspended()`? See also comment on declaration of `_suspend_requested`.

Fixed

> src/hotspot/share/runtime/handshake.cpp line 720:
> 
>> 718:   MutexLocker ml(&_lock, Mutex::_no_safepoint_check_flag);
>> 719:   // Can't be suspended if there is no suspend request.
>> 720:   if (!is_suspend_requested()) {
> 
> Shouldn't `is_suspend_requested()` be replaced with `is_suspended()`? See also comment on declaration of `_suspend_requested`.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191