RFR: 8257831: Suspend with handshakes [v2]

Robbin Ehn rehn at openjdk.java.net
Tue Apr 6 09:43:24 UTC 2021


On Tue, 30 Mar 2021 13:36:17 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/prims/jvmtiRawMonitor.cpp line 323:
> 
>> 321:       // Suspend request flag can only be set in handshakes.
>> 322:       // By blocking handshakes, suspend request flag cannot change its value.
>> 323:       if (!jt->handshake_state()->is_suspend_requested()) {
> 
> Shouldn't `jt->handshake_state()->is_suspend_requested()` be replaced with `jt->is_suspended()`? See also comment on declaration of `_suspend_requested`.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the serviceability-dev mailing list