RFR: 8257831: Suspend with handshakes [v2]

Robbin Ehn rehn at openjdk.java.net
Wed Apr 7 14:36:43 UTC 2021


On Wed, 31 Mar 2021 06:57:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> test/hotspot/jtreg/serviceability/jvmti/SuspendWithCurrentThread/SuspendWithCurrentThread.java line 132:
> 
>> 130:             ThreadToSuspend.setAllThreadsReady();
>> 131: 
>> 132:             while (!checkSuspendedStatus()) {
> 
> The changes to this test are still quite unclear to me. Too hard to figure out what the test was originally trying to do!

The test worked because we didn't check for suspend when leaving a safepoint request back to native.
@pchilano have more info on why the test even works today.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the serviceability-dev mailing list