RFR: 8257831: Suspend with handshakes [v3]

[Robbin Ehn]

On Thu, 1 Apr 2021 03:21:55 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/handshake.hpp line 151:
> 
>> 149: 
>> 150:   bool is_suspended()                 { return Atomic::load(&_suspended); }
>> 151:   void set_suspend(bool to)           { return Atomic::store(&_suspended, to); }
> 
> Maybe set_suspended() instead()?

Fixed

> src/hotspot/share/runtime/objectMonitor.cpp line 436:
> 
>> 434:     current->set_current_pending_monitor(NULL);
>> 435: 
>> 436:     // We cleared the pending monitor info since we've just gotten past
> 
> Comment below needs updating since it mentions ThreadBlockInVM but we are not using it anymore.

Fixed

> src/hotspot/share/runtime/thread.cpp line 277:
> 
>> 275: #endif
>> 276: 
>> 277:   _SR_lock = new Monitor(Mutex::suspend_resume, "SR_lock", true,
> 
> Mutex::suspend_resume rank is not used by any other monitor so we could remove it.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191