RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]
    Aleksey Shipilev 
    shade at openjdk.java.net
       
    Fri Apr  9 08:54:18 UTC 2021
    
    
  
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to Ahead-of-Time Compiler from JDK: 
>> 
>> - `jdk.aot` module — the `jaotc` tool 
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution 
>> - related HotSpot code guarded by `#if INCLUDE_AOT` 
>> 
>> Additionally, remove tests as well as code in makefiles related to AoT compilation.
>> 
>> Tested hs-tier1-4
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove exports from Graal module to jdk.aot
Shenandoah parts look good. I have a few minor comments after reading the rest.
src/hotspot/cpu/x86/globalDefinitions_x86.hpp line 73:
> 71: 
> 72: #if INCLUDE_JVMCI
> 73: #define COMPRESSED_CLASS_POINTERS_DEPENDS_ON_COMPRESSED_OOPS (EnableJVMCI)
Minor nit: can probably drop parentheses here.
src/hotspot/share/code/compiledIC.cpp line 715:
> 713:     tty->print("interpreted");
> 714:   } else {
> 715:     tty->print("unknown");
We can probably split this cleanup into the minor issue, your call. The benefit of separate issue: backportability.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3398
    
    
More information about the serviceability-dev
mailing list