RFR: 8260517: implement Sealed Classes as a standard feature in Java [v2]

[Vicente Romero]

On Fri, 16 Apr 2021 02:10:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hi Vicente,
> 
> Hotspot and hotspot tests all look fine. One query: why was this test removed?
> 
> test/hotspot/jtreg/runtime/sealedClasses/AbstractSealedTest.java
> 
> is that functionality tested elsewhere? (The other deleted test seemed obviously trivial.)
> 
> Thanks,
> David

Hi David, thanks for your comments, yes regarding `test test/hotspot/jtreg/runtime/sealedClasses/AbstractSealedTest.java`, it was removed because the functionality is tested in `test/langtools/tools/javac/sealed/SealedCompilationTests.java`

> src/hotspot/share/classfile/classFileParser.cpp line 3916:
> 
>> 3914:             record_attribute_start = cfs->current();
>> 3915:             record_attribute_length = attribute_length;
>> 3916:           } else if (_major_version >= JAVA_17_VERSION) {
> 
> Can you update the comment at L3932 to say JAVA_17_VERSION please.

sure

-------------

PR: https://git.openjdk.java.net/jdk/pull/3526