RFR: 8234532: Remove ThreadLocalAllocBuffer::_fast_refill_waste since it is never set [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Thu Apr 29 07:08:54 UTC 2021


On Wed, 28 Apr 2021 09:41:14 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> It has some cascading effect; two performance variables, `fastWaste` and `maxFastWaste`, can be removed also.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - merge
>  - refill

Lgtm apart from that minor formatting nit.

src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp line 109:

> 107:                                    _slow_refill_waste);
> 108:   } else {
> 109:     assert(_number_of_refills == 0 &&

Please fill back the clause from the next line. I think the assert condition now fits a single line, the text may be on the next line

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3756


More information about the serviceability-dev mailing list