RFR: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use" [v2]

[Alex Menkov]

On Tue, 3 Aug 2021 18:35:20 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Additional code cleanup as requested by reviewer
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attachnosuspend/attachnosuspend001.java line 101:
> 
>> 99:         String cmd = java
>> 100:                 + " -Xdebug -Xnoagent -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=0"
>> 101:                 + " " + DEBUGEE_CLASS;
> 
> You've lost logging of the port you end up listening on. Is the dynamically discovered listening port logged somewhere else?

DebugeeProcess.redirectOutputAndDetectListeningAddress logs it
(see DebugeeProcess.java, line 428)
Also IORedirector logs debugee output (including "Listening for transport ... at address ..." line)

> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 330:
> 
>> 328:      */
>> 329:     public void redirectStdout(Log log, String prefix) {
>> 330:         redirectStdout(log, prefix, null);
> 
> Is there a reason to still support passing in the prefix even though it is ignored. Seems that could be confusing to someone looking at the caller code.

I dont' quite follow.
The prefix is not ignored, it's passed to IORedirector and is used for logging

-------------

PR: https://git.openjdk.java.net/jdk/pull/4817