RFR: 8269685: Optimize HeapHprofBinWriter implementation [v4]

[Serguei Spitsyn]

On Fri, 13 Aug 2021 10:46:02 GMT, Lin Zang <lzang at openjdk.org> wrote:

>> This PR rewrite the implementation of the HeapHprofBinWriter, which could simplify the logic of current implementation.
>> please see detail description at https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into hprof
>  - fix write size issue
>  - Merge branch 'master' into hprof
>  - 8269685: Optimize HeapHprofBinWriter implementation

Lin, in order to see my inlined comment you need to look at "Files changed".
I still miss something. If these methods have to be empty then what is the purpose to have them?
Also, a couple of new empty methods are not used, so the question is why do you add them:
  calculateGlobalJNIHandlesDumpRecordSize, calculateJavaThreadsDumpRecordSize

-------------

PR: https://git.openjdk.java.net/jdk/pull/4666