RFR: 8269685: Optimize HeapHprofBinWriter implementation [v3]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Tue Aug 24 10:19:29 UTC 2021
On Mon, 5 Jul 2021 12:04:17 GMT, Lin Zang <lzang at openjdk.org> wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could simplify the logic of current implementation.
>> please see detail description at https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>
> fix write size issue
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java line 141:
> 139: return 0;
> 140: }
> 141:
Hi Lin,
I don't like these empty methods in this abstract class.
Should they be just abstract instead?
Thanks,
Serguei
-------------
PR: https://git.openjdk.java.net/jdk/pull/4666
More information about the serviceability-dev
mailing list