RFR: 8277481: Obsolete seldom used CDS flags

[Calvin Cheung]

On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this change to obsolete deprecated CDS options UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64.
> 
> The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem list.
> 
> Thanks! Harold

Looks good. Just one nit.

src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c line 303:

> 301:       useSharedSpacesAddr = lookup_symbol(ph, jvm_name, USE_SHARED_SPACES_SYM);
> 302:       if (useSharedSpacesAddr == 0) {
> 303:         print_debug("can't lookup 'UseSharedSpaces' symbol\n");

Maybe the `print_debug` at line 311 should also be updated from "flag" to "symbol"?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6800