RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v2]
Chris Plummer
cjplummer at openjdk.java.net
Fri Dec 10 20:30:44 UTC 2021
On Fri, 10 Dec 2021 12:22:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
> Hi Chris,
> It looks good in general. I feel the parameter 'retry' is a little bit confusing. It is possible to rename it to some to 'retriedOnce'. Another approach would be to name it 'allowRetry' and revert the meaning of boolean value.
> I leave it up to you to keep the original approach or make any change.
> Thanks,
> Serguei
Ok. I changed it to allowRetry.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6795
More information about the serviceability-dev
mailing list