RFR: 8225093: Special property jdk.boot.class.path.append should not default to empty string

David Holmes dholmes at openjdk.java.net
Fri Dec 17 02:26:25 UTC 2021


On Thu, 16 Dec 2021 17:33:29 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this fix for JDK-8225093 to set the default value of property jdk.boot.class.path.append to NULL instead of "".  This fix was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.  The fix was also tested by running the agent.c example in JDK-8224791.
> 
> Thanks! Harold

Hi Harold,

Change looks good and I've Reviewed the CSR request.

One nit in the test.

Thanks,
David

test/hotspot/jtreg/runtime/BootClassAppendProp/GetBootClassPathAppendProp.java line 40:

> 38: 
> 39:     public static void main(String[] args) throws Exception {
> 40:         String vm_info_jvmti = getSystemProperty();

Nit: strange name and doesn't follow Java style rules. Won't "path" suffice?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6868


More information about the serviceability-dev mailing list