RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

[Chris Plummer]

On Tue, 21 Dec 2021 21:28:43 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix issue with address range patterns. For some reason they have always allowed some extra lower case letters at the end of the pattern that just get ignored. I removed support for this since sometimes it resulted in bad address ranges producing an exception rather than a usage() message.
>>  - Fix missing return after calling usage()
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java line 197:
> 
>> 195:                                           "In interpreter codelet: method entry point"));
>> 196:             runTest(withCore, cmds, expStrMap);
>> 197: 
> 
> Is there a test case for another variant of range: Address,Address ?

No. We really never had any specific test cases for `examine`. ClhsdbFindPC does make use of it, but not for the addr,addr variant, so it was also omitted for `mem`. I did consider adding a test case for it and still can. I started down that path, but adding an incremental value to a hex String was getting a bit ugly, so I abandoned it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6902