RFR: JDK-8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out [v2]

[Serguei Spitsyn]

On Tue, 2 Feb 2021 12:00:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi,
>> 
>> may I please have reviews for this trivial fix.
>> 
>> We see timeouts with this test on slow large (memory wise) AIX machines, as well as large core files.
>> 
>> This test is a negative test which tests that the VM corectly recognizes an error condition and aborts. Code goes through jni_FatalError()->os::abort(), writes a core and aborts the process.
>> 
>> No parameters are given for that VM invocation, so heap size depends on machine size. On my Linux box, the generated core takes about 500m. On AIX we see cores of 16G and more.
>> 
>> The difference between AIX and other platforms is that AIX does not have the notion of "committing" memory (we have no MAP_NORESERVE flag), so all mmapped memory counts toward the commit charge from the moment it is mapped. That makes core files on AIX annoyingly large. I'd expect a similar behavior on other platforms with overcommit disabled.
>> 
>> The fix is to run the test without CreateCoredumpOnCrash. For good measure, I also reduced the heap size to 128m.
>> 
>> Thanks to @ArnoZeller for figuring that one out.
>> 
>> 
>> -----
>> Tests: manual jtreg tests, verifying that no cores are written.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary CreateCoredumpOnCrash

The update looks good.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2332