RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

Alex Menkov amenkov at openjdk.java.net
Tue Feb 2 20:48:42 UTC 2021


On Tue, 2 Feb 2021 20:34:14 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Thanks @plummercj for your review.
>> 
>> Let's wait for @alexmenkov 's comments.
>> Thanks.
>
> Special handling for options with commas, quotes and single quotes was added many years ago for JFR (as it uses commas inside). The logic there is a bit tricky and I didn't want to brake existing functionality when I made some changes there, so I used "live" examples of JRF options in the test.
> I don't know other VM options which use commas inside.

As the test verifies correct parsing of "options", I think it's ok to use IgnoreUnrecognizedVMOptions here

-------------

PR: https://git.openjdk.java.net/jdk/pull/2346


More information about the serviceability-dev mailing list