RFR: 8260296: SA's dumpreplaydata fails [v3]
Roland Westrelin
roland at openjdk.java.net
Thu Feb 4 09:44:13 UTC 2021
On Wed, 3 Feb 2021 18:51:57 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Thanks for reviewing this. I did not store the pid in the OutputAnalyzer because it doesn't seem to belong there as it has nothing to do with the text output of a test. But if you think that's ok. that's fine with me too. Do you prefer an extra field in OutputAnalyzer or a new subclass?
>
> `OutputAnalyzer`/ `OutputBuffer` already have an exit value, which arguable has nothing to do w/ the text output either, so I think it's ok to add a pid into `OutputBuffer` i-face and both of its implementations.
I just pushed a change that does this. Does that look ok to you?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2195
More information about the serviceability-dev
mailing list