RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

David Holmes david.holmes at oracle.com
Fri Feb 5 05:01:10 UTC 2021


Hi Anton,

On 4/02/2021 6:01 am, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
> 
> Anton Kozlov has updated the pull request incrementally with six additional commits since the last revision:
> 
>   - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>   - Add comments to WX transitions
>     
>     + minor change of placements
>   - Use macro conditionals instead of empty functions
>   - Add W^X to tests
>   - Do not require known W^X state
>   - Revert w^x in gtests

These updates to the w^x code look good to me, this is much improved in 
terms of the pervasiveness/intrusiveness. Hopefully there can still be 
further refinement in the future (after the initial integration).

Thanks,
David

> -------------
> 
> Changes:
>    - all: https://git.openjdk.java.net/jdk/pull/2200/files
>    - new: https://git.openjdk.java.net/jdk/pull/2200/files/3c705ae5..80827176
> 
> Webrevs:
>   - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2200&range=09
>   - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2200&range=08-09
> 
>    Stats: 444 lines in 64 files changed: 112 ins; 278 del; 54 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/2200.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/2200/head:pull/2200
> 
> PR: https://git.openjdk.java.net/jdk/pull/2200
> 


More information about the serviceability-dev mailing list