RFR: 8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed

[Alex Menkov]

On Fri, 5 Feb 2021 22:11:39 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
>> The fix un-problemlists RemovingUnixDomainSocketTest and changes serviceability tests to use OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings instead of stderrShouldBeEmptyIgnoreVMWarnings
>
> Overall it looks good, but as @dcubed-ojdk hinted, sufficient mach5 testing is necessary. VM warning issues turn up during testing when extra VM options are used during various tiers and "specialized" test tasks. Simply running the tests in question through mach5 or locally isn't enough.

> 
> 
> What kind of testing was done in Mach5?

I run all affected tests with default arguments and with "-XX:NativeMemoryTracking=detail"

> 
> Overall it looks good, but as @dcubed-ojdk hinted, sufficient mach5 testing is necessary. VM warning issues turn up during testing when extra VM options are used during various tiers and "specialized" test tasks. Simply running the tests in question through mach5 or locally isn't enough.

Do you have some ideas what to run?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2438