RFR: 8248876: LoadObject with bad base address created for exec file on linux [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Sun Feb 7 02:25:06 UTC 2021
On Sat, 6 Feb 2021 17:03:26 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unnecessary comments
>
> Looks good, I made a suggestions elsewhere in the PR about the comments at line 510...
@kevinjwalls Thank you for the comment!
> I found the "svr4_exec_displacement() in GDB" more confusing than informative, maybe this is the same technique GDB uses... But I followed our dynamic_addr setting and agree with the new changes.
I removed it in new commit.
> An alternative comment could be this, which would also removes the "substract" typo (which was not yours!):
It's my change in [JDK-8173941](https://bugs.openjdk.java.net/browse/JDK-8173941).
I removed it too.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2366
More information about the serviceability-dev
mailing list