RFR: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" [v2]

Chris Plummer cjplummer at openjdk.java.net
Thu Feb 11 23:13:40 UTC 2021


On Wed, 3 Feb 2021 23:28:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   separated debuggee class name and args
>
> test/jdk/com/sun/jdi/JdbOptions.java line 91:
> 
>> 89:         // the simplest case
>> 90:         test("-connect",
>> 91:                 "com.sun.jdi.CommandLineLaunch:vmexec=java,options=-client -XX:+PrintVMOptions,main=" + targ + outFileArg)
> 
> Not to be too nit picky, but I was assuming that the " " would be here and not in outFileName. That would make it much more obvious how the args are separated (eg we are not using commas here).

> @plummercj are you ok with the latest version?

Yes. thank you

-------------

PR: https://git.openjdk.java.net/jdk/pull/2322


More information about the serviceability-dev mailing list