RFR: 8261607: SA attach is exceeding JNI Local Refs capacity [v3]

[Chris Plummer]

On Mon, 15 Feb 2021 18:09:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Although no Clhsdb test is explicitly always runs with `-Xcheck:jni`, the option can be added to any test run. For example:
>> 
>> `$ make test  TEST=open/test/hotspot/jtreg/serviceability/sa/ TEST_VM_OPTS="-Xcheck:jni"`
>> 
>> This matching is done to make sure there are no warnings when the test is run in this manner. The matching could be conditional on the test being run with  `-Xcheck:jni`, but I don't really see to point in cluttering up the logic with such a check since the warnings should never appear, whether or not you are using `-Xcheck:jni`.
>
> OK, I thought so. Could you expand on the comment saying so, please? Suggestion: `Make sure there are no -Xcheck:jni warnings as -Xcheck:jni might be set via TEST_VM_OPTS on test runs`.

Ok, the comment has been updated. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2568