RFR: 8261447: MethodInvocationCounters frequently run into overflow [v4]

Lutz Schmidt lucy at openjdk.java.net
Tue Feb 16 15:20:17 UTC 2021


> Dear community,
> may I please request reviews for this fix, improving the usefulness of method invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow probability way out (185 days in case of a 1 GHz counter update frequency).
> - counters for individual methods are interpreted as (unsigned int), in contrast to their declaration as int. This gives us a factor of two before the counters overflow.
> - as a special case, "compiled_invocation_counter" is retyped as long, because it has a higher update frequency than other counters.
> - before/after sample output is attached to the bug description. 
> 
> Thank you!
> Lutz

Lutz Schmidt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - 8261447: requested changes by TobiHartmann
 - JDK-8261447: MethodInvocationCounters frequently run into overflow
 - expand remaining counters to 64-bit, remove 64 duffix
 - 8261447: requested changes by TobiHartmann
 - JDK-8261447: MethodInvocationCounters frequently run into overflow

-------------

Changes: https://git.openjdk.java.net/jdk/pull/2511/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=03
  Stats: 5969 lines in 92 files changed: 5856 ins; 4 del; 109 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2511.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2511/head:pull/2511

PR: https://git.openjdk.java.net/jdk/pull/2511


More information about the serviceability-dev mailing list