RFR: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so

[Daniel D.Daugherty]

On Tue, 16 Feb 2021 09:10:17 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> See bug description for details. The fix is simple and just a matter of moving some code to avoid incorrectly thinking an address is in a .so when it is in some other area of VM memory that occurs just after the last .so.
>
> Looks good.

While I was characterizing:

    JDK-8261844 serviceability/sa/ClhsdbFindPC.java#id1 failed with "'In code in NMethod for LingeredAppWithTrivialMain.main' missing from stdout/stderr"

I determined that I could easily reproduce serviceability/sa/ClhsdbFindPC.java failures
on my Ubuntu 16.04 test machine. I've applied this version of this PR:

$ git log HEAD^!
commit fea1ed851ce6a93030169e7de0daac2c2ac12a31 (HEAD -> pull/2562)
Author: Chris Plummer <chris.plummer at oracle.com>
Date:   Sat Feb 13 19:02:24 2021 +0000

    Check if addr is in DSO last to avoid finding addr in DSO when it is not due to DSO.size() returning too large of a value.

and retested. I no longer see serviceability/sa/ClhsdbFindPC.java failures.
I did a total of 6 runs (X3 configs) and there were no failures.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2562