RFR: 8261447: MethodInvocationCounters frequently run into overflow [v6]
Lutz Schmidt
lucy at openjdk.java.net
Tue Feb 16 22:04:10 UTC 2021
> Dear community,
> may I please request reviews for this fix, improving the usefulness of method invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow probability way out (185 days in case of a 1 GHz counter update frequency).
> - counters for individual methods are interpreted as (unsigned int), in contrast to their declaration as int. This gives us a factor of two before the counters overflow.
> - as a special case, "compiled_invocation_counter" is retyped as long, because it has a higher update frequency than other counters.
> - before/after sample output is attached to the bug description.
>
> Thank you!
> Lutz
Lutz Schmidt has updated the pull request incrementally with two additional commits since the last revision:
- no incrementq for x86_32
- cleaning up the remaining mess
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2511/files
- new: https://git.openjdk.java.net/jdk/pull/2511/files/0a99ee4e..faab64b0
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=05
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=04-05
Stats: 30 lines in 5 files changed: 0 ins; 15 del; 15 mod
Patch: https://git.openjdk.java.net/jdk/pull/2511.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2511/head:pull/2511
PR: https://git.openjdk.java.net/jdk/pull/2511
More information about the serviceability-dev
mailing list