RFR: 8261447: MethodInvocationCounters frequently run into overflow [v7]

Lutz Schmidt lucy at openjdk.java.net
Wed Feb 17 18:22:01 UTC 2021


> Dear community,
> may I please request reviews for this fix, improving the usefulness of method invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow probability way out (185 days in case of a 1 GHz counter update frequency).
> - counters for individual methods are interpreted as (unsigned int), in contrast to their declaration as int. This gives us a factor of two before the counters overflow.
> - as a special case, "compiled_invocation_counter" is retyped as long, because it has a higher update frequency than other counters.
> - before/after sample output is attached to the bug description. 
> 
> Thank you!
> Lutz

Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:

  update copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2511/files
  - new: https://git.openjdk.java.net/jdk/pull/2511/files/faab64b0..0f220ee3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=05-06

  Stats: 8 lines in 6 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2511.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2511/head:pull/2511

PR: https://git.openjdk.java.net/jdk/pull/2511


More information about the serviceability-dev mailing list