RFR: 8261269: When using clhsdb to "inspect" a java object, clhsdb prints "Oop for..." twice [v2]

Chris Plummer cjplummer at openjdk.java.net
Thu Feb 18 06:43:01 UTC 2021


> See CR for details. In brief, fixed the `inspect` command to remove duplicate output:
> 
> hsdb> inspect 0x00000007fef00770
> instance of Oop for java/lang/Class @ 0x00000007fef00770 @ 0x00000007fef00770 (size = 160)
> in: Oop for java/io/BufferedInputStream @ 0x0000000082005b08 Oop for java/io/BufferedInputStream @ 0x0000000082005b08
> out: Oop for java/io/PrintStream @ 0x0000000082007b60 Oop for java/io/PrintStream @ 0x0000000082007b60
> err: Oop for java/io/PrintStream @ 0x000000008200e0c8 Oop for java/io/PrintStream @ 0x000000008200e0c8 
> It should be:
> 
> hsdb> inspect 0x00000007fef00770
> instance of Oop for java/lang/Class @ 0x00000007fef00770 (size = 160)
> in: Oop for java/io/BufferedInputStream @ 0x0000000082005b08
> out: Oop for java/io/PrintStream @ 0x0000000082007b60
> err: Oop for java/io/PrintStream @ 0x000000008200e0c8

Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:

  Put replicated strings into a local variable.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2582/files
  - new: https://git.openjdk.java.net/jdk/pull/2582/files/d5a300c3..1304bd78

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2582&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2582&range=00-01

  Stats: 8 lines in 1 file changed: 2 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2582.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2582/head:pull/2582

PR: https://git.openjdk.java.net/jdk/pull/2582


More information about the serviceability-dev mailing list