Integrated: 8261098: Add clhsdb "findsym" command

Chris Plummer cjplummer at openjdk.java.net
Fri Feb 19 01:01:40 UTC 2021


On Mon, 15 Feb 2021 05:51:07 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Add "findsym" to clhsdb. See the CR and CSR for details. The [CSR](https://bugs.openjdk.java.net/browse/JDK-8261101) still needs a reviewer.
> 
> There is a fix in LinuxDebuggerLocal_lookupByName0() to allow passing in NULL for the dso name. This is allowed, and in fact even not null it gets ignored. It is needed by the new findsym support in order for the following to work, which passes in null for the dso name:
> 
> `    Address addr = VM.getVM().getDebugger().lookup(null, symbol);`
> 
> There is one other somewhat unrelated fix in the test:
> 
>  -            String value = parts[1];
>  +           String value = parts[1].split(linesep)[0];
> 
> This is suppose to capture just the value at the specified address, but it also captures the newline and some text after. The result if that when `findpc <value>` is executed, it also executes another command or two of garbage commands after that, which produce errors. They were not impacting the test, but were noticeable in the log. I first noticed it when similar code in the new part of the test had the same issue.

This pull request has now been integrated.

Changeset: c158413e
Author:    Chris Plummer <cjplummer at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c158413e
Stats:     83 lines in 4 files changed: 75 ins; 0 del; 8 mod

8261098: Add clhsdb "findsym" command

Reviewed-by: amenkov, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/2567


More information about the serviceability-dev mailing list