RFR: 8253940: com/sun/jdi/JdwpAttachTest.java failed with "RuntimeException: ERROR: LingeredApp.startApp was able to attach" [v2]

[Alex Menkov]

On Fri, 19 Feb 2021 20:30:19 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated per Chris feedback
>
> test/jdk/com/sun/jdi/JdwpAttachTest.java line 180:
> 
>> 178:     // loopback address.
>> 179:     // The method checks if the address is safe to test with current network config.
>> 180:     private static boolean addressIfSafeToConnectToLocalhost(InetAddress addr) {
> 
> Do you really mean to name it "addressIfSafe..." rather than "addressIsSafe..."?

Correct. Fixed.

> test/jdk/com/sun/jdi/JdwpAttachTest.java line 178:
> 
>> 176:     // Attach to localhost tries to connect to both IPv4 and IPv6 loopback addresses.
>> 177:     // But sometimes it causes interference with other processes which can listen on the same port but different
>> 178:     // loopback address.
> 
> Move a few words from the end of the 2nd line of the comment down to the 3rd.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2654