RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v20]

[Lin Zang]

On Sat, 20 Feb 2021 10:48:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Lin Zang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix indentation isue
>>  - fix help message issue and Use ByteBuffer for integer writing
>
> Hi Lin,
> I'm sorry for the delay.
> The fix looks good to me.
> I have one minor request below.
> 
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> 
> +    private static byte[] genByteArrayFromInt(int integer) {
> . . .
> +        private final void writeInteger(int v) {
> 
> Could you, please, replace both parameters 'integer' and 'v' with something like 'val' or 'value'?
> 
> Thanks,
> Serguei

Hi Serguei,
> Could you, please, replace both parameters 'integer' and 'v' with something like 'val' or 'value'?
Done.
Thanks a lot for reviewing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712