RFR: 8261710: SA DSO objects have sizes that are too large [v5]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Sat Feb 20 12:30:43 UTC 2021


On Sat, 20 Feb 2021 09:55:18 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Fix comments
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8261710
>>  - Use p_filesz instead of p_memsz
>>  - Remove unnecessary code
>>  - Fix for OS X
>>  - Use entire of address range of shared library
>>  - 8261710: SA DSO objects have sizes that are too large
>
> Marked as reviewed by sspitsyn (Reviewer).

@sspitsyn Thanks for the review!

> > lib->end is declared as unsigned (uintptr_t), so we can't use (lib->end < aligned_end) when lib->end is set to -1.

> Could we use the 0L instead of -1L? What's wrong with 0L?

I prefer to use -1 instead of 0 for invalid value because we can't distinguish NULL or invalid value if we use 0.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2563


More information about the serviceability-dev mailing list