RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v4]

[Andrew John Hughes]

On Fri, 12 Feb 2021 12:49:19 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too.
>
> Hi Harold,
> 
>> Thanks for doing this! Sorry for taking so long to review this change. The change looks good.
> 
> Thanks for the review!
> 
>> Before pushing it, could you add a comment explaining what the code in lines 185-194 of CgroupSubsystemFactory.java is doing?
> 
> Done.
> 
>> Also, please don't overwrite the fix for JDK-8257746.
> 
> AFAIK this patch doesn't touch this code. So this should not happen (overwrite of the fix). FWIW, once this is in I intend to propose a patch which adds a regression test for JDK-8257746. It would depend on this change.
> 
> Thanks,
> Severin

Thanks, this version looks better.
Sorry for the delay. I didn't realise you'd replied until I received your e-mail. Not sure where notifications for these git PRs end up.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1393