RFR: 8259037: livenmethods cannot find hsdis library [v2]

[Serguei Spitsyn]

On Tue, 5 Jan 2021 01:14:12 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> `livenmethods` CLHSDB command could not find hsdis library even though it deployed to `$JAVA_HOME/lib/server/`.
>> 
>> sun.jvm.hotspot.debugger.DebuggerException: /usr/local/jdk-15.0.1/lib/amd64/hsdis-amd64.so: cannot open shared object file: No such file or directory
>>         at jdk.hotspot.agent/sun.jvm.hotspot.asm.Disassembler.load_library(Native Method)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.asm.Disassembler.<init>(Disassembler.java:95)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.asm.Disassembler.decode(Disassembler.java:52)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.asm.Disassembler.decode(Disassembler.java:43)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.ui.classbrowser.HTMLGenerator.genHTML(HTMLGenerator.java:1435)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor$45.doit(CommandProcessor.java:1651)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:2051)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:2021)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.run(CommandProcessor.java:1901)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:99)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:40)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.runCLHSDB(SALauncher.java:280)
>>         at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.main(SALauncher.java:483)
>> 
>> JDK directory layout has been changed since JDK 9, however `livenmethods` hasn't followed it yet.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some comments, remove unnecessary code

Hi Yasumasa,

The fix looks good to me.
How has it been tested/verified?

Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1920