RFR: 8258032: Reconsider LEAF entry restrictions [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Jan 6 17:19:05 UTC 2021


On Tue, 5 Jan 2021 14:37:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 353:
>> 
>>> 351: #define VM_LEAF_BASE(result_type, header)                            \
>>> 352:   TRACE_CALL(result_type, header)                                    \
>>> 353:   debug_only(NoHandleMark __hm;)                                     \
>> 
>> Shouldn't `NoSafepointVerifier` be added here and then it can be removed from `JRT_LEAF`?
>
> I don't want a NoSafepointVerifier in JNI_LEAF, and the equivalent fromNative JVM_LEAF, which "calls" this.  I only want it in JRT_LEAF.  JNI_LEAF isn't really a leaf, it often calls JNI functions that transition to the VM.

Do you want to file a cleanup bug to rename JNI_LEAF to something more appropriate?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1846


More information about the serviceability-dev mailing list