RFR: 8259067: bootclasspath append takes out object lock [v3]

[Coleen Phillimore]

On Wed, 6 Jan 2021 22:06:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move locking into function where exclusive access is needed.
>
> src/hotspot/share/classfile/classLoader.cpp line 837:
> 
>> 835:       _last_append_entry = new_entry;
>> 836:       assert(first_append_entry() == NULL, "boot loader's append class path entry list not empty");
>> 837:       Atomic::store(&_first_append_entry_list, new_entry);
> 
> This should probably be `OrderAccess::release_store`.

Ok, thanks.

> src/hotspot/share/classfile/classLoader.hpp line 220:
> 
>> 218:   static ClassPathEntry* volatile _first_append_entry_list;
>> 219:   static ClassPathEntry* first_append_entry() {
>> 220:     return Atomic::load(&_first_append_entry_list);
> 
> This should probably be a load_acquire.

Okay, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1935