RFR: 8258652: Assert in JvmtiThreadState::cur_stack_depth() can noticeably slow down debugging single stepping

Wed Jan 13 22:41:05 UTC 2021

On Thu, 7 Jan 2021 22:32:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> This works but I'm concerned if this sets a precedent for adding expensive assertions? Do we already have similar flags?
>
>> This works but I'm concerned if this sets a precedent for adding expensive assertions? Do we already have similar flags?
> 
> @dholmes-ora The one expensive assert is already there. I have since removed the two additional expensive asserts for the incr() and decr() APIs. I don't know of any other similar flag.

Ping! Still need 2 reviews for this one too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1835