RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]
Leonid Mesnik
lmesnik at openjdk.java.net
Thu Jan 14 20:32:17 UTC 2021
> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of strcmp results here:
>
> for (i=0; i<METH_NUM; i++)
> if (strcmp(methNam,METHODS[i][0]) &&
> strcmp(methSig,METHODS[i][1])) {
> printf("CHECK PASSED: method name: "%s"\tsignature: "%s" %d\n",
> methNam, methSig, i);
> if (checkStatus == PASSED)
> bpEvents[i]++;
> break;
> }
>
> So test passed when both strcmp (name,sig) are not zero.
>
> The test passes only because there are 2 methods that are checked and it increases counters for "incorrect" methods.
Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
copyrights and ident fixed
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2084/files
- new: https://git.openjdk.java.net/jdk/pull/2084/files/009db2ef..c7b78f85
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2084&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2084&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/2084.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2084/head:pull/2084
PR: https://git.openjdk.java.net/jdk/pull/2084
More information about the serviceability-dev
mailing list