RFR: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect [v2]

[Serguei Spitsyn]

On Thu, 14 Jan 2021 20:32:17 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of strcmp results here:
>> 
>>   for (i=0; i<METH_NUM; i++)
>>         if (strcmp(methNam,METHODS[i][0]) &&
>>                 strcmp(methSig,METHODS[i][1])) {
>>             printf("CHECK PASSED: method name: "%s"\tsignature: "%s" %d\n",
>>                    methNam, methSig, i);
>>             if (checkStatus == PASSED)
>>                 bpEvents[i]++;
>>             break;
>>         }
>> 
>> So test passed when both strcmp (name,sig) are not zero.
>> 
>> The test passes only because there are 2 methods that are checked and it increases counters for "incorrect" methods.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyrights and ident fixed

Hi Leonid,
LGTM++
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2084