Integrated: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
Leonid Mesnik
lmesnik at openjdk.java.net
Fri Jan 15 19:36:06 UTC 2021
On Thu, 14 Jan 2021 19:09:59 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of strcmp results here:
>
> for (i=0; i<METH_NUM; i++)
> if (strcmp(methNam,METHODS[i][0]) &&
> strcmp(methSig,METHODS[i][1])) {
> printf("CHECK PASSED: method name: "%s"\tsignature: "%s" %d\n",
> methNam, methSig, i);
> if (checkStatus == PASSED)
> bpEvents[i]++;
> break;
> }
>
> So test passed when both strcmp (name,sig) are not zero.
>
> The test passes only because there are 2 methods that are checked and it increases counters for "incorrect" methods.
This pull request has now been integrated.
Changeset: d7d34dd9
Author: Leonid Mesnik <lmesnik at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/d7d34dd9
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
Reviewed-by: iignatyev, sspitsyn, cjplummer
-------------
PR: https://git.openjdk.java.net/jdk/pull/2084
More information about the serviceability-dev
mailing list