RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v6]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Tue Jan 19 08:15:52 UTC 2021


On Tue, 19 Jan 2021 05:43:12 GMT, Lin Zang <lzang at openjdk.org> wrote:

>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code refine

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/JMap.java line 161:

> 159:                             dumpfile = keyValue[1];
> 160:                         } else if (keyValue[0].equals("gz")) {
> 161:                             String level = keyValue[1];

Same comment in above.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 1788:

> 1786:                     String[] keyValue = option.split("=");
> 1787:                     if (keyValue[0].equals("gz")) {
> 1788:                         String level = keyValue[1];

If the user specified `gz` option incorrectly (e.g. `dumpheap gz` : without the level), `ArrayIndexOutOfBoundsException` will be thrown.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712


More information about the serviceability-dev mailing list