RFR: 8251462: Remove legacy compilation policy [v4]

Igor Veresov iveresov at openjdk.java.net
Fri Jan 22 17:23:47 UTC 2021


On Wed, 20 Jan 2021 20:52:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check legacy flags validity before deriving flag values for emulation mode.
>
> src/hotspot/share/compiler/compilerDefinitions.hpp line 243:
> 
>> 241:   static bool is_c1_only_no_aot_or_jvmci() {
>> 242:     return is_c1_only() && !is_aot() && !is_jvmci();
>> 243:   }
> 
> These names are a little confusing: what about C2, why only no AOT and JVMCI. I understand that you want to check if JVMCI or AOT can install their compiled code.
> May be `is_c1_nmethods_only`, `is_c1_nmethods_or_interpreter_only` ?

I guess it's a matter of naming convention. What I tried to make the CompilerConfig API about is to check if compilers are present/enabled and in which combination. Of course presence of a compiler implies that we're going to see nmethod produced by it. I'd like to keep the current naming if it's not a huge eyesore for you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1985


More information about the serviceability-dev mailing list