RFR: 8259778: Merge MutableSpace and ImmutableSpace

David Holmes dholmes at openjdk.java.net
Thu Jan 28 05:22:39 UTC 2021


On Wed, 27 Jan 2021 23:06:41 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change which merges ImmutableSpace into MutableSpace,
> eliminating the former.  There were no interesting uses of ImmutableSpace,
> other than as the base class for MutableSpace.  The name ImmutableSpace is
> kind of a misnomer given that usage.
> 
> Testing:
> mach5 tier1-3

This looks good to me.

And I deifnitely agree that a MutableSpace is-not-a ImmutableSpace!

One minor nit below.

Thanks,
David

src/hotspot/share/gc/parallel/mutableSpace.hpp line 47:

> 45: //
> 46: // Invariant: bottom() <= top() <= end()
> 47: // top() is inclusive and end() is exclusive.

If end() is exclusive then shouldn't the invariant be `< end()`?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2271


More information about the serviceability-dev mailing list