[jdk17] RFR: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code

David Holmes dholmes at openjdk.java.net
Fri Jul 23 06:38:03 UTC 2021


On Fri, 23 Jul 2021 04:34:50 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review the patch that adds an exit-code check to `serviceability/jvmti/GetObjectSizeClass.java` test?
> 
> from JBS:
>> `serviceability/jvmti/GetObjectSizeClass.java` test spawns a new JVM but doesn't check its exit code which might lead to both type-I and type-II errors
> 
> testing:  `serviceability/jvmti/GetObjectSizeClass.java`  on `{linux,windows,macos}-x64`
> 
> Thanks,
> -- Igor

Looks good and trivial.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/277


More information about the serviceability-dev mailing list