RFR: 8265148: StackWatermarkSet being updated during AsyncGetCallTrace

[Leonid Mesnik]

On Tue, 1 Jun 2021 04:09:13 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> Let me check with Erik if it makes sense to put more generic comments about the usage of stackwatermark frame processing in RegisterMap, frames etc.  They can't be updated in an arbitrary thread state. It makes sense describe this info in stackwatermarking.
>
>> Let me check with Erik if it makes sense to put more generic comments about the usage of stackwatermark frame processing in RegisterMap, frames etc.  They can't be updated in an arbitrary thread state. It makes sense describe this info in stackwatermarking.
> 
> You could say something generic like "StackWatermark can only be used when at points where the stack can be parsed by the GC", or something like that.

Thank you for your prompt response. I meant that it makes sense to update comments for RegisterMap to mention this. Currently, the doc says how to use it and how to disable update:
"Updating of the RegisterMap can be turned off by instantiating the
//      register map as: RegisterMap map(thread, false);"
But it says nothing about why and how  process_frames should be set.
It might make sense to put this info there so anyone could easily find and read it. I think it is better to put it there rather than in forte.cpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4217