RFR: 8266337: ThreadTimesClosure doesn't handle exceptions properly

[David Holmes]

On Tue, 1 Jun 2021 21:54:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> 8266337: ThreadTimesClosure doesn't handle exceptions properly

Hi Leonid,

This change looks good to me.

Thanks,
David

src/hotspot/share/services/management.cpp line 1708:

> 1706:     Threads::threads_do(&ttc);
> 1707:   }
> 1708:   ttc.do_unlocked(THREAD);

At first I thought this should use CHECK_0 not THREAD so it will return zero when an exception occurs. But this goes straight back to Java code so the exception will propagate and the return value can't be examined.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4292