RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v2]

Alan Bateman alanb at openjdk.java.net
Wed Jun 2 08:47:32 UTC 2021


On Fri, 28 May 2021 10:49:32 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Please review a small change that adds an option to GC.heap_dump to use an existing file. 
>> 
>> The option is necessary if the target file is a predefined file-like object, like a named pipe. This opens up a lot of possibilities to process a heap dump without storing it to the file system first.
>> 
>> Reviews of the CSR linked to the bug would be appreciated as well.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Extend HeapDumpTest

I think the named pipe scenario needs more discussion. For the more simpler case of overwriting an existing file then opt-in in with an option like `-overwrite` might be clearer than `-rewrite`. It's important that we choose the right name because there are several commands that may need to do the same.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4183


More information about the serviceability-dev mailing list