RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash [v2]

[Daniel D.Daugherty]

On Thu, 3 Jun 2021 17:24:07 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Fixed a race condition between posting and enabling DynamicCodeGenerated event.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed comment

Thumbs up.

I just have minor comments.

Just curious: what's the execution times for the new test on the Mach5 platforms?

test/hotspot/jtreg/serviceability/jvmti/DynamicCodeGenerated/libDynamicCodeGenerated.cpp line 27:

> 25: #include <jvmti.h>
> 26: 
> 27: jvmtiEnv* jvmti;

Should this be 'static'?

test/hotspot/jtreg/serviceability/jvmti/DynamicCodeGenerated/libDynamicCodeGenerated.cpp line 35:

> 33: JNIEXPORT
> 34: void JNICALL Java_DynamicCodeGeneratedTest_changeEventNotificationMode(JNIEnv* jni, jclass cls) {
> 35:   while(true) {

nit - please add space before '('

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4331