RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v3]

Alan Bateman alanb at openjdk.java.net
Sun Jun 6 05:34:17 UTC 2021


On Sat, 5 Jun 2021 15:51:49 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> I would suggest to change the CSR to use "overwrite" but other than that, it seems fine. Let's wait what Alan has to say but that would be my thinking.

Using "-overwrite" to opt-in to overwrite an existing file looks good to me.

The CSR still has wording to suggest that the new option is also to support socket/other files. I read the PR as just the overwrite existing file case. If so then maybe those (two) sentences can be changed in the CSR to make it clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4183


More information about the serviceability-dev mailing list