RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]

Christoph Langer clanger at openjdk.java.net
Sun Jun 6 06:19:04 UTC 2021


On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Please review a small change that adds an option to GC.heap_dump to use an existing file. 
>> 
>> The option is necessary if the target file is a predefined file-like object, like a named pipe. This opens up a lot of possibilities to process a heap dump without storing it to the file system first.
>> 
>> Reviews of the CSR linked to the bug would be appreciated as well.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix windows flags (although complied fine)

Thanks Alan for commenting on that one.

> The CSR still has wording to suggest that the new option is also to support socket/other files. I read the PR as just the overwrite existing file case. If so then maybe those (two) sentences can be changed in the CSR to make it clearer.

I think it's ok to mention the use-cases like pipe support which is something that'll be enabled by this change. But feel free to remove it. I've marked the CSR as reviewed from my end.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4183


More information about the serviceability-dev mailing list