RFR: 8268361: Fix the infinite loop in next_line [v2]
UncleNine
github.com+1964054+unclenine at openjdk.java.net
Tue Jun 8 16:46:16 UTC 2021
On Tue, 8 Jun 2021 16:21:34 GMT, UncleNine <github.com+1964054+UncleNine at openjdk.org> wrote:
>> It is not obvious to me that the caller of next_line will handle the fact that we have hit EOF?
>
> In my case, it happened in the container environment.
> the /proc filesystem of the container is provided by lxcfs, but a lxcfs bug may make the /proc/stat mount point change, then the file descriptor is different and fgetc function returns an EOF on error, But c != '\n' is true and it leads to the infinit loop.
> Below are our flamegraph in the production , it happends on serveral frameworks(micrometer, elasticsearch..)which use the api "sun/management/OperatingSystemImpl.getSystemCpuLoad"
> 
I use top -Hp $PID command and the thread show 100% cpu usage


-------------
PR: https://git.openjdk.java.net/jdk/pull/4378
More information about the serviceability-dev
mailing list